gh-198: enforce python>3.8 & numpy>1.21
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
the
infrastructure
This was referenced Oct 4, 2024
Saransh-cpp
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198. For Array API support (#67), we need minimum versions of:
Python 3.9as specified here https://data-apis.org/array-api-compat/changelog.html#id9NumPy 1.22as specified here https://numpy.org/doc/stable/reference/array_api.html#array-api-standard-compatibilityIn this PR I have enforced both of these. The code changes have come from
rufflinting, utilising the benefits from 3.9.I also removed some of the overzealous comments on imports. They weren't adding anything and meant the imports took up more room.