Only uses AST-parser for .html.erb

- Fixes #537
glebm · Dec 30, 2023 · 56bd296 · 56bd296
1 parent 30b7703
commit 56bd296
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,7 @@
+## Unreleased
+
+* ErbAst-parser now only used for `*.html.erb`-files, not e.g. `*.js.erb`
+
 ## v1.0.13
 
 * OpenAI translator.

diff --git a/lib/i18n/tasks/used_keys.rb b/lib/i18n/tasks/used_keys.rb
@@ -21,8 +21,8 @@ module UsedKeys # rubocop:disable Metrics/ModuleLength
       relative_roots: %w[app/controllers app/helpers app/mailers app/presenters app/views].freeze,
       scanners: [
         ['::I18n::Tasks::Scanners::RubyAstScanner', { only: %w[*.rb] }],
-        ['::I18n::Tasks::Scanners::ErbAstScanner', { only: %w[*.erb] }],
-        ['::I18n::Tasks::Scanners::PatternWithScopeScanner', { exclude: %w[*.erb *.rb] }]
+        ['::I18n::Tasks::Scanners::ErbAstScanner', { only: %w[*.html.erb] }],
+        ['::I18n::Tasks::Scanners::PatternWithScopeScanner', { exclude: %w[*.html.erb *.rb] }]
       ],
       ast_matchers: [],
       strict: true

diff --git a/spec/fixtures/app/views/ignore.js.erb b/spec/fixtures/app/views/ignore.js.erb
@@ -0,0 +1,2 @@
+// This is javascript file
+<% # i18n-tasks-use t('hello.world') %>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// This is javascript file
		<% # i18n-tasks-use t('hello.world') %>