Identify and translate missing plural keys #596
Conversation
| @@ -23,6 +23,7 @@ en: | |||
| nostdin: Do not read from stdin | |||
| out_format: 'Output format: %{valid_text}' | |||
| pattern_router: 'Use pattern router: keys moved per config data.write' | |||
| skip_interpolation: Skip translating strings that are straight interpolations (eg. "%{comment}") | |||
There was a problem hiding this comment.
Rather than adding an option, perhaps we should always simply copy such keys verbatim? There is never a reason to translate them.
There was a problem hiding this comment.
That would be preferential in our use case but I didn't want to assume...
There was a problem hiding this comment.
Actually we don't even copy them, we have Rails configured with fallback which then just works... Not sure that's a safe assumption either though.
There was a problem hiding this comment.
There is never any reason to pass interpolation-only values through machine translation, so let's copy them verbatim?
There was a problem hiding this comment.
Sounds good to me! :)
Edit: Although in our case we don't want to copy them either, I'd prefer to skip and leave them to fallback. Should I leave a mechanism in place for that?
There was a problem hiding this comment.
Sure, makes sense to have that as an option.
spec/translator_spec.rb
Outdated
| describe 'multi-line' do | ||
|
|
||
| end |
|
I spent a little more time on this on a large translation (~610 keys in 30 locales) and added a tweak. Namely, ChatGPT is pretty bad at returning the correct number of responses back, I've added the array size to the prompt but even then it struggles if there are repeated translations - so there's a fail safe that'll retry and then fall back to doing line by line. I also found dropping the default array size from 50 to 25 improved things somewhat. Edit: Looks like there's a problem with the removal of pluralization keys that aren't required, eg we translate |
I fixed this in 7e47ded I think a separate task to remove plurals from locales that are not required would be kinda useful as a distinct thing. |
markedmondson
force-pushed
the
pluralization
branch
from
a4ac302 to
e804c6a
Compare
markedmondson
force-pushed
the
pluralization
branch
2 times, most recently
from
0fdd55f to
179e0b1
Compare
markedmondson
force-pushed
the
pluralization
branch
from
6cf2d85 to
76ecc39
Compare
From #582
translatecommands, determines the existing and required pluralization keys and adds the nodes to the forest before translating. It will additionally remove unrequired plural translation keys.missingcommand as the table headers were a little unclear.missingcommand (but specifically intended for translation) that won't send only interpolated strings to translate, the reasoning behind this was a) I found OpenAI would end up getting a mismatched number of results returned if there were a lot of them and b) it's kind of wasteful as a correctly configured Rails implementation would fallback and work correctly.I think there's still some cleanup to do here, it feels a little clobbered together as I was learning as I went so totally happy to solicit feedback (or hear and attempt to address any problems).