-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow individual label images to be converted #135
base: master
Are you sure you want to change the base?
Allow individual label images to be converted #135
Conversation
Thanks @melissalinkert I copied some of our public OME-Zarr data locally for testing (s3://gs-public-zarr-archive/TCGA-OR-A5JB-01A-01-TS1.B68B5BAF-B262-4DAA-9F47-A285B3C497AF.ome.zarr).
I believe this error is happening due to a mismatch in the channel count (although it says I would expect all spatial dimensions to match between the label image and image: X, Y and Z. |
Can do. Should mismatches in the T dimension be allowed as well? |
I propose we only allow mismatches in C, given we understand the reason for this. So let's please include X, Y, Z and T in dimensions that should match between the image and label image. |
This loosens some of the restrictions on the Zarr hierarchy, and adds a
-f
option so that metadata can be copied from an existing image file.I'd expect
raw2ometiff input.zarr/0/labels/abc_mask/ mask.ome.tiff -f /path/to/original/image/file
to be the pattern to use here, which would convert a single label image to a single OME-TIFF. If there are multiple label images underinput.zarr/0/labels/
, they would each need to be converted separately. The use of-f
means thatinput.zarr/OME/METADATA.ome.xml
does not need to exist (and in fact, would be ignored if it did).Fake data can easily be used to test the
-f
option. If any of the XYZCT dimensions are incorrect, an informative exception should be thrown.Assigning just @erindiel for now to make sure the required functionality has been captured correctly; can assign code reviewers afterwards.