Add var and varh for austrian Smart meter of Energie Steiermark #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's wrong approach, it will broke other meeters which reports in var unit's in this obis.. Better fix would be accept both value of units and make conversation to one unique. |
killer0071234
commented
Mar 20, 2024
Comment on lines
-305
to
+307
| DEFINE_FIELD(total_imported_energy, FixedValue, ObisId(1, 0, 3, 8, 0), FixedField, units::kvarh, units::kvarh); | ||
| DEFINE_FIELD(total_imported_energy, FixedValue, ObisId(1, 0, 3, 8, 0), FixedField, units::kvarh, units::varh); |
There was a problem hiding this comment.
It's wrong approach, it will broke other meeters which reports in var unit's in this obis..
Better fix would be accept both value of units and make conversation to one unique.
I am no sure what you mean exactly..?
but shall not do that change the trick?
I had done it similar to other DEFINE_FIELD entrys.
BR
There was a problem hiding this comment.
Oh its templates, hard to read, also i think i was worng also by implementing these lines of code..
Cloud you add dump of your meeter for those obis values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A readout of Austrian power meters from energy supplier
Energie Steiermarkis only possible with that change.Type of smart meter:
Sagemcom T210-Dsmart meter documentation
This change is tested with 3 different smart meters of that type.
BR Daniel