-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra connect status #814
base: develop
Are you sure you want to change the base?
Extra connect status #814
Conversation
Travis automatic deployment: |
@hpmaxi can't you just show the same a non connected user would see? If you can't, a message like "You need to unlock or connect your wallet" could be more appropriate. |
…er into bug/empty-screen-metamask-not-unblocked
@gabitoesmiapodo To show what a non connected user would see we need to connect to infura while the code is inside the I did another version but is stashed because it doesn't behave very well. In this version, the modal appears when you switch between networks. It far from ideal. |
Travis automatic deployment: |
…er into bug/empty-screen-metamask-not-unblocked
Travis automatic deployment: |
Travis automatic deployment: |
@hpmaxi , I have checked the fix.
Could you please take a look into these issues? Or let me know, whether I need to create additional tasks for them. |
Closes #614
Finally, this is working and the solution has also improved. This uses an intermediate state and some logic was moved outside the connects functions to avoid re-running effects that generated a loop in a previous solution.
To get this working there were two extra changes.
cachedProvider
(this is effect logic)