-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating langfuse integration #345
Changes from 19 commits
53b0251
a2ba1ca
5fc4fed
379d867
eb60f02
48be281
2857653
e3deb37
f59c14d
c43d0cd
94e84ab
900e59b
303dcaf
4eff02e
572021e
bd9883e
7d25064
dcab73c
041ac59
78935d0
6cf9c0c
b615f31
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,8 +40,9 @@ class APIKeys(BaseSettings): | |
GOOGLE_SEARCH_ENGINE_ID: t.Optional[SecretStr] = None | ||
|
||
LANGFUSE_SECRET_KEY: t.Optional[SecretStr] = None | ||
LANGFUSE_PUBLIC_KEY: t.Optional[SecretStr] = None | ||
LANGFUSE_PUBLIC_KEY: t.Optional[str] = None | ||
LANGFUSE_HOST: t.Optional[str] = None | ||
LANGFUSE_DEPLOYMENT_VERSION: t.Optional[str] = None | ||
|
||
TAVILY_API_KEY: t.Optional[SecretStr] = None | ||
|
||
|
@@ -127,7 +128,7 @@ def langfuse_secret_key(self) -> SecretStr: | |
) | ||
|
||
@property | ||
def langfuse_public_key(self) -> SecretStr: | ||
def langfuse_public_key(self) -> str: | ||
return check_not_none( | ||
self.LANGFUSE_PUBLIC_KEY, "LANGFUSE_PUBLIC_KEY missing in the environment." | ||
) | ||
|
@@ -138,6 +139,14 @@ def langfuse_host(self) -> str: | |
self.LANGFUSE_HOST, "LANGFUSE_HOST missing in the environment." | ||
) | ||
|
||
@property | ||
def default_enable_langfuse(self) -> bool: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is used as the default argument in DeployableAgent init method There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's not necessary for langfuse to work, it can be |
||
return ( | ||
self.LANGFUSE_SECRET_KEY is not None | ||
and self.LANGFUSE_PUBLIC_KEY is not None | ||
and self.LANGFUSE_HOST is not None | ||
) | ||
|
||
@property | ||
def tavily_api_key(self) -> SecretStr: | ||
return check_not_none( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new env variable that is populated by git commit sha in PMA's docker building pipeline; it will show us, in the UI, what version of PMA was used.