Refactoring and removing check.v1 #20
Conversation
Signed-off-by: Paulo Gomes <[email protected]>
This representation is mostly useful within the context of go-git-fixtures. go-billy Filesystem interface is too generic, which makes this implementation violate the Liskov Principle. When more narrow representations of the filesystem are available in go-billy, this could be moved upstream. Signed-off-by: Paulo Gomes <[email protected]>
pjbgf
force-pushed
the
improve-tests
branch
2 times, most recently
from
8251fe9 to
276b7c3
Compare
The refactoring achieves a few goals: - Support for fully in-memory execution, without the need of extracting tgz files into disk. - Removal of the deprecated check.v1 dependency. Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
| tmpPrefix = "tmp-tgz-" | ||
| ) | ||
|
|
||
| type Option func(*options) |
|
We should probably add lint configs to enforce rules like comments and code quality |
|
@aymanbagabas added some linters and fixed the initial issues, we can expand the linters list as we go. We should roll them out across the other repositories as well. PTAL |
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
| test: | ||
| $(GOTEST) ./... | ||
|
|
||
| generate: $(esc) | ||
| $(GOCMD) generate | ||
| validate: validate-lint validate-dirty ## Run validation checks. |
There was a problem hiding this comment.
Is this necessary? Instead, we can use a build workflow to run the linter. Contributors should have their editor linter set up.
There was a problem hiding this comment.
The idea here is mostly to align CI and local, with the least amount of assumptions about a developer/contributors' environment.
There was a problem hiding this comment.
Merging it as is, but happy to discuss further what this should look like across the org.
| - name: Validate | ||
| if: matrix.platform == 'ubuntu-latest' | ||
| run: make validate |
There was a problem hiding this comment.
| - name: Validate | |
| if: matrix.platform == 'ubuntu-latest' | |
| run: make validate | |
| - name: Validate | |
| if: matrix.platform == 'ubuntu-latest' | |
| run: make validate |
This PR refactors this library. Summary of changes:
billy.Filesystemthat is based on an underlyingembed.FS.