-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): Add options to skip version check for Minio storage to resolve compatible problem #33166
base: main
Are you sure you want to change the base?
Conversation
Please use English for the title. Thanks. |
Wait, the fix seems not correct. It seems that the root reason is not from this place. According to the document, According to the document, But the error log is |
yes, this is my config.
and this is log. my image is gitea/gitea:1.22.3-rootless And I change this version control from COS. However, opening or closing it always fails. |
I don't have Tentent Cloud environment to test it deeply. Maybe you can change the log level to trace, and run mode to dev, to get more logs. It seems that this version check is for checking whether the config is correct, so skipping it not seems good (IMO). |
@@ -52,6 +52,7 @@ type MinioStorageConfig struct { | |||
ChecksumAlgorithm string `ini:"MINIO_CHECKSUM_ALGORITHM" json:",omitempty"` | |||
ServeDirect bool `ini:"SERVE_DIRECT"` | |||
BucketLookUpType string `ini:"MINIO_BUCKET_LOOKUP_TYPE" json:",omitempty"` | |||
SkipVersionCheck bool `ini:"SKIP_VERSION_CHECK" json:",omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
Could you add a minio prefix to this setting, as well add documentation to the app.example.ini file?
I encountered an error while using Tencent COS object storage. The logs are as follows, and it seems incompatible. According to the relevant code comments, I found that this can be skipped.
it worked now