-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add validator for IPv4 bind address / host:port #1282
Open
rtomadpg
wants to merge
1
commit into
go-playground:master
Choose a base branch
from
rtomadpg:feat-add-ipv4port
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supporting older Golang versions by using net.ParseIP, not netip.ParseAddr
rtomadpg
force-pushed
the
feat-add-ipv4port
branch
from
June 17, 2024 09:52
9597b0f
to
e022a95
Compare
nodivbyzero
reviewed
Dec 10, 2024
Comment on lines
+2711
to
+2728
ip, port, err := net.SplitHostPort(val) | ||
if err != nil { | ||
return false | ||
} | ||
// Port must be a iny <= 65535. | ||
if portNum, err := strconv.ParseInt( | ||
port, 10, 32, | ||
); err != nil || portNum > 65535 || portNum < 1 { | ||
return false | ||
} | ||
|
||
// If IP address is specified, it should match a valid IPv4 address | ||
if ip != "" { | ||
// we need to support older Golang versions, so we can not use netip.ParseAddr | ||
parsedIp := net.ParseIP(ip) | ||
return parsedIp != nil && parsedIp.To4() != nil | ||
} | ||
return true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More readable and concise implementation:
Suggested change
ip, port, err := net.SplitHostPort(val) | |
if err != nil { | |
return false | |
} | |
// Port must be a iny <= 65535. | |
if portNum, err := strconv.ParseInt( | |
port, 10, 32, | |
); err != nil || portNum > 65535 || portNum < 1 { | |
return false | |
} | |
// If IP address is specified, it should match a valid IPv4 address | |
if ip != "" { | |
// we need to support older Golang versions, so we can not use netip.ParseAddr | |
parsedIp := net.ParseIP(ip) | |
return parsedIp != nil && parsedIp.To4() != nil | |
} | |
return true | |
host, port, err := net.SplitHostPort(val) | |
if err != nil { | |
return false | |
} | |
// Validate port range (1-65535). | |
if portNum, err := strconv.ParseUInt(port, 10, 32,); err != nil || portNum < 1 || portNum > 65535 { | |
return false | |
} | |
// If no host is specified, return true (valid) | |
if host == "" { | |
return true | |
} | |
// Parse and validate IPv4 address | |
ip := net.ParseIP(host) | |
return ip != nil && ip.To4() != nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Here is a little PR to say thank you, for providing your framework.
Let's add a validator for IPv4 bind addresses.
Examples of valid input:
:9000
for port 9000 on any IP address1.2.3.4:7777
for port 7777 on specific IP addressMy use case: I need this validator for an application's config including IP based socket listener addresses, like:
:9999
or127.0.0.1:9999
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers