Optimize qos initializer. #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-878-74132af \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-878-74132af \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-878-74132af \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-878-74132af crane/craneCoding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-878-74132af \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-878-74132af \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-878-74132af \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-878-74132af crane/craneGhcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-878-74132af \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-878-74132af \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-878-74132af \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-878-74132af crane/crane |
mfanjie
reviewed
Nov 29, 2023
tools/initializer/resource.yaml
Outdated
| matchLabels: | ||
| app: nginx | ||
| initContainerTemplate: | ||
| name: crane-qos-initializer | ||
| name: qos-initializer-container |
There was a problem hiding this comment.
nit: name: qos-initializer is fine
| image: docker.io/gocrane/qos-init:v0.1.6 | ||
| imagePullPolicy: IfNotPresent | ||
| args: | ||
| - "while ! grep -q gocrane.io/cpu-qos /etc/podinfo/annotations; do sleep 1; done; echo cpu qos setting competed;" |
There was a problem hiding this comment.
if it's just a shell call, do we still need qos-init image, can it be changed to pause?
There was a problem hiding this comment.
oh, pause does not contain those shell command, ignore this
pkg/webhooks/pod/mutating.go
Outdated
| @@ -28,7 +40,7 @@ func (m *MutatingAdmission) Default(ctx context.Context, obj runtime.Object) err | |||
| return fmt.Errorf("expected a Pod but got a %T", obj) | |||
| } | |||
|
|
|||
| klog.Infof("Into Pod injection %s/%s", pod.Namespace, pod.Name) | |||
| klog.Infof("mutating started for pod %s/%s", pod.Namespace, pod.Name) | |||
There was a problem hiding this comment.
A code standard, all logs start with Capital letters, and please check if a log level should be added and disabled the msg by default. same suggestion to all newly added logs
pkg/webhooks/pod/mutating.go
Outdated
| if m.Config.QOSInitializer.InitContainerTemplate != nil { | ||
| pod.Spec.InitContainers = append(pod.Spec.InitContainers, *m.Config.QOSInitializer.InitContainerTemplate) | ||
| if !ls.Matches(labels.Set(pod.Labels)) { | ||
| klog.Infof("injection skipped: webhook is not interested in the pod") |
There was a problem hiding this comment.
injection->Injection, and this is a debug log, I suggest to add a log level and do not enable by default, and if we have label config for the webhook, this line of code should not be called?
There was a problem hiding this comment.
In fact, I don't like this logic. But in order to be compatible with the previous design, I still leave the matching here.
mfanjie
reviewed
Nov 29, 2023
pkg/ensurance/analyzer/analyzer.go
Outdated
| @@ -6,6 +6,8 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "github.com/gocrane/crane/pkg/ensurance/util" | |||
There was a problem hiding this comment.
move this to the crane import section
payall4u
force-pushed
the
feature/pod-initializer
branch
from
58fdc3f to
74132af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature.
What this PR does / why we need it:
Optimize qos initializer webhook. Inject init-container and init-volume only when pod matched by offline pod qos.
Which issue(s) this PR fixes:
From #876
Special notes for your reviewer: