Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-integrate virtual compat methods #1007

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Jan 10, 2025

Reverts #991's commit 60e48ff.
Makes godot-rust ready for GDExtension's compatibility feature (godotengine/godot#100674).

CI will fail until upstream PR is merged.

@Bromeon Bromeon added feature Adds functionality to the library status: upstream Depending on upstream fix (typically Godot) c: ffi Low-level components and interaction with GDExtension API labels Jan 10, 2025
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1007

@Bromeon Bromeon force-pushed the feature/virtual-compat-methods-2 branch from a797f08 to 614631e Compare January 11, 2025 23:02
Revert "Minimal changes to make PR mergeable before upstream virtual-compat is ready"
This reverts commit 60e48ff.
@Bromeon Bromeon force-pushed the feature/virtual-compat-methods-2 branch from 614631e to 95feb9b Compare January 12, 2025 07:12
@Bromeon Bromeon added this pull request to the merge queue Jan 12, 2025
Merged via the queue into master with commit 4a49529 Jan 12, 2025
15 checks passed
@Bromeon Bromeon deleted the feature/virtual-compat-methods-2 branch January 12, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: ffi Low-level components and interaction with GDExtension API feature Adds functionality to the library status: upstream Depending on upstream fix (typically Godot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants