Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 feat: Add support for iterator methods to Fiber client #3228
🔥 feat: Add support for iterator methods to Fiber client #3228
Changes from 2 commits
0949f42
7578ae3
26a3439
b57b7c2
b4c7c54
86e93b1
3e1d427
7488d53
0343f06
bb43f28
cd9b6c9
0b71163
65c0448
fa4c54a
40361f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 276 in client/hooks.go
GitHub Actions / lint
Check failure on line 276 in client/hooks.go
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VisitAll
in its current form does not support early returns. If the caller of the iterator stops iterating early (e.g. bybreak
infor range
),yield
would be called again after it returnedfalse
, and this causes a runtime panic.Please update
VisitAll
to support early returns, and add a test to verify that stopping the iterator early works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the report. Will fix it
Check failure on line 734 in client/request.go
GitHub Actions / lint
Check failure on line 735 in client/request.go
GitHub Actions / lint
Check failure on line 742 in client/request.go
GitHub Actions / lint
Check failure on line 742 in client/request.go
GitHub Actions / lint
Check failure on line 751 in client/request.go
GitHub Actions / lint
Check failure on line 759 in client/request.go
GitHub Actions / lint
Check failure on line 874 in client/request.go
GitHub Actions / lint
Check failure on line 875 in client/request.go
GitHub Actions / lint