build: Add release_version.h to control the TF wheel filename and maintain reproducible wheel content and filename results.
#488
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_715441698
branch
from
a64a103 to
028c75d
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_715441698
branch
3 times, most recently
from
b79f5b4 to
a6ec705
Compare
copybara-service
bot
changed the title
release_version.h file.
copybara-service
bot
force-pushed
the
test_715441698
branch
3 times, most recently
from
923dcf8 to
ff83d92
Compare
copybara-service
bot
changed the title
release_version.h file.release_version.h to control the TF wheel filename and maintain reproducible wheel content and filename results.
copybara-service
bot
force-pushed
the
test_715441698
branch
2 times, most recently
from
098ae23 to
75cc5ce
Compare
…aintain reproducible wheel content and filename results.
It enables ability to pass defines values to `//tensorflow/core/public:release_version`.
Instead of having TF version in three places (`setup.py`, `version.h` and `tensorflow.bzl`), it should be located in one place only. Declaration of TF version in a new `tf_version.bzl` file will allow passing this value to build rules wrapping `setup.py` and `release_version.h`.
Dependency on `//tensorflow/core/public:release_version` should be added if `TF_MAJOR_VERSION, TF_MINOR_VERSION, TF_PATCH_VERSION, TF_VERSION_SUFFIX` values are used in the code.
Dependency on `//tensorflow/core/public:version` should be added if graphDef compatibility versions or checkpoint compatibility versions are used in the code.
The next step would be to change cc_library release_version in the following way:
```
cc_library(
name = "release_version",
hdrs = ["release_version.h"],
defines = [
"TF_MAJOR_VERSION={}".format(MAJOR_VERSION),
"TF_MINOR_VERSION={}".format(MINOR_VERSION),
"TF_PATCH_VERSION={}".format(PATCH_VERSION),
"TF_VERSION_SUFFIX={}".format(TF_SEMANTIC_VERSION_SUFFIX),
],
visibility = ["//visibility:public"],
)
```
The version chunks will be created from the value in `tf_version.bzl`. The version suffix will be created by a new repository rule, and it will be controlled by environment variables.
PiperOrigin-RevId: 715441698
copybara-service
bot
force-pushed
the
test_715441698
branch
from
75cc5ce to
1f0341f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: Add
release_version.hto control the TF wheel filename and maintain reproducible wheel content and filename results.It enables ability to pass defines values to
//tensorflow/core/public:release_version.Instead of having TF version in three places (
setup.py,version.handtensorflow.bzl), it should be located in one place only. Declaration of TF version in a newtf_version.bzlfile will allow passing this value to build rules wrappingsetup.pyandrelease_version.h.Dependency on
//tensorflow/core/public:release_versionshould be added ifTF_MAJOR_VERSION, TF_MINOR_VERSION, TF_PATCH_VERSION, TF_VERSION_SUFFIXvalues are used in the code.Dependency on
//tensorflow/core/public:versionshould be added if graphDef compatibility versions or checkpoint compatibility versions are used in the code.The next step would be to change cc_library release_version in the following way:
The version chunks will be created from the value in
tf_version.bzl. The version suffix will be created by a new repository rule, and it will be controlled by environment variables.