Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode redirect URL value #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

2m
Copy link
Contributor

@2m 2m commented Aug 9, 2020

I am not completely sure why does encodeRedirectURL not handle this. Documentation for this method states that it tries to determine whether encoding is needed or not. And for some reason it does not encode provided redirectURL.

When redirectURL is not encoded, only the first argument (code) is then taken from the URL in the /link endpoint.

When redirectURL is encoded, both code and state is parsed from the URL correctly and Google endpoint does not complain about missing state argument anymore.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@2m
Copy link
Contributor Author

2m commented Aug 9, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants