Add function to get proto from hex and throughput value #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 30, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 30, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
ondrasej
approved these changes
Dec 30, 2024
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
boomanaiden154
added a commit
to boomanaiden154/gematria
that referenced
this pull request
Dec 31, 2024
This patch adds a new function to bhive_importer to directly create a BasicBlockWithThroughputProto from a basic block in hex format and its associated throughput value. No unittests are added on the C++ side as this is a refactoring. A unit test is added on the python side to test the bindings for the new function. This is intended to be used in the benchmarking pipeline where formatting everything as a CSV before passing it into the bhive importer makes little sense. Pull Request: google#274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new function to bhive_importer to directly create a
BasicBlockWithThroughputProto from a basic block in hex format and its
associated throughput value. No unittests are added on the C++ side as
this is a refactoring. A unit test is added on the python side to test
the bindings for the new function. This is intended to be used in the
benchmarking pipeline where formatting everything as a CSV before
passing it into the bhive importer makes little sense.