Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for storing basic block context in Gematria formats. #288

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for storing basic block context in Gematria formats. #288

wants to merge 2 commits into from

Conversation

virajbshah
Copy link
Collaborator

  • Add fields to the proto specification to store context.
  • Add members to the Gematria BasicBlock data structure to store context and update methods on it and its Python binding accordingly.
  • Bonus: Remove dangling TODO.

@virajbshah
Add support for storing basic block context in Gematria formats.
c0da27c 
 * Add fields to the `proto` specification to store context.
 * Add members to the Gematria `BasicBlock` data structure to store
   context and update methods on it and its Python binding accordingly.
 * Bonus: Remove dangling TODO.
@virajbshah
Copy link
Collaborator Author

Bumping the C++ formatting CI version from v4.11.0 (clang-format-16) -> v4.14.0 (clang-format-19) should be enough to fix that failing check, though I'm not sure if re-running it after the update will use the new version without adding another commit to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrasej ondrasej Awaiting requested review from ondrasej

@boomanaiden154 boomanaiden154 Awaiting requested review from boomanaiden154

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@virajbshah