add map between severity and overdue minutes #1144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiud
requested changes
Jan 19, 2025
| @@ -337,6 +338,16 @@ const char* GetLogSeverityName(LogSeverity severity) { | |||
| return LogSeverityNames[severity]; | |||
| } | |||
|
|
|||
| LogSeverity FindFilepathLogSeverity(const std::string& filepath) { | |||
| for (int i = GLOG_INFO; i < NUM_SEVERITIES; i++) { | |||
| if (filepath.find(GetLogSeverityName(static_cast<LogSeverity>(i))) != std::string::npos) { | |||
There was a problem hiding this comment.
Suggested change
| if (filepath.find(GetLogSeverityName(static_cast<LogSeverity>(i))) != std::string::npos) { | |
| if (filepath.rfind(GetLogSeverityName(static_cast<LogSeverity>(i))) != std::string::npos) { |
Search from right since the severity is used as a suffix.
| return static_cast<LogSeverity>(i); | ||
| } | ||
| } | ||
| // assume that the file has the INFO severity |
There was a problem hiding this comment.
Do not assume anything and simply return a not found sentinel.
| @@ -1286,7 +1299,14 @@ LogCleaner::LogCleaner() = default; | |||
|
|
|||
| void LogCleaner::Enable(const std::chrono::minutes& overdue) { | |||
| enabled_ = true; | |||
| overdue_ = overdue; | |||
| for (int i = GLOG_INFO; i < NUM_SEVERITIES; i++) { | |||
| overdue_per_severity_[static_cast<LogSeverity>(i)] = overdue; | |||
There was a problem hiding this comment.
Fill the map only with the severity set by the user.
| @@ -2627,6 +2654,10 @@ void EnableLogCleaner(const std::chrono::minutes& overdue) { | |||
| log_cleaner.Enable(overdue); | |||
| } | |||
|
|
|||
| void EnableLogCleaner(std::unordered_map<LogSeverity, std::chrono::minutes>& overdue_per_severity) { | |||
There was a problem hiding this comment.
Exposing the map as a parameter makes the calls verbose and the API usage unnecessarily complicated. Instead use the following signature:
Suggested change
| void EnableLogCleaner(std::unordered_map<LogSeverity, std::chrono::minutes>& overdue_per_severity) { | |
| void EnableLogCleaner(LogSeverity severity, const std::chrono::minutes& overdue) { |
| void EnableLogCleaner(std::unordered_map<LogSeverity, std::chrono::minutes>& overdue_per_severity) { | ||
| log_cleaner.Enable(overdue_per_severity); | ||
| } | ||
|
|
||
| void DisableLogCleaner() { log_cleaner.Disable(); } |
There was a problem hiding this comment.
For symmetry, there should be an API call for disabling the log cleaner for specific severity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an
unordered_mapthat can store a severity and it's corresponding overdue time to theLogCleanerobject. The modifications should be backwards compatible. If this idea is correct, we can preform some optimizations, like keeping a cache of filepaths whose severities have been computed.Fixes: #882