Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ClosingFuture, remove a workaround for [JDK-7101822](https://bugs.openjdk.java.net/browse/JDK-7101822)(?) now that we [build with a JDK after JDK 8](https://github.com/google/guava/issues/6549). This follows up on cl/332225001 and cl/643394004. #7554

Merged
merged 1 commit into from
Dec 16, 2024
Merged

In ClosingFuture, remove a workaround for [JDK-7101822](https://bugs.openjdk.java.net/browse/JDK-7101822)(?) now that we [build with a JDK after JDK 8](https://github.com/google/guava/issues/6549). This follows up on cl/332225001 and cl/643394004. #7554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions android/guava/src/com/google/common/util/concurrent/ClosingFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,9 +1223,7 @@ private Peeker(ImmutableList<ClosingFuture<?>> futures) {
* .closing(executor);
* }</pre>
*/
// TODO(cpovirk): Use simple name instead of fully qualified after we stop building with JDK 8.
@com.google.errorprone.annotations.DoNotMock(
"Use ClosingFuture.whenAllSucceed() or .whenAllComplete() instead.")
@DoNotMock("Use ClosingFuture.whenAllSucceed() or .whenAllComplete() instead.")
public static class Combiner {

private final CloseableList closeables = new CloseableList();
Expand Down
4 changes: 1 addition & 3 deletions guava/src/com/google/common/util/concurrent/ClosingFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,9 +1228,7 @@ private Peeker(ImmutableList<ClosingFuture<?>> futures) {
* .closing(executor);
* }</pre>
*/
// TODO(cpovirk): Use simple name instead of fully qualified after we stop building with JDK 8.
@com.google.errorprone.annotations.DoNotMock(
"Use ClosingFuture.whenAllSucceed() or .whenAllComplete() instead.")
@DoNotMock("Use ClosingFuture.whenAllSucceed() or .whenAllComplete() instead.")
public static class Combiner {

private final CloseableList closeables = new CloseableList();
Expand Down
Loading