Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate linkshared as appropriate in mozc_win32_cc_prod_binary #1153

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Propagate linkshared as appropriate in mozc_win32_cc_prod_binary #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/build_defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ def mozc_win32_cc_prod_binary(
deps = [],
features = None,
linkopts = [],
linkshared = False,
cpu = CPU.X64,
static_crt = False,
tags = MOZC_TAGS.WIN_ONLY,
Expand All @@ -362,6 +363,7 @@ def mozc_win32_cc_prod_binary(
deps: deps to build the executable.
features: features to be passed to mozc_cc_binary.
linkopts: linker options to build the executable.
linkshared: True if the target is a shared library (DLL).
cpu: optional. The target CPU architecture.
static_crt: optional. True if the target should be built with static CRT.
tags: optional. Tags for both the library and unit test targets.
Expand All @@ -377,7 +379,7 @@ def mozc_win32_cc_prod_binary(
deps = deps,
features = features,
linkopts = linkopts,
linkshared = static_crt,
linkshared = linkshared,
tags = tags,
target_compatible_with = target_compatible_with,
visibility = visibility,
Expand Down
1 change: 1 addition & 0 deletions src/win32/custom_action/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ mozc_win32_cc_prod_binary(
"Mozc": "mozc_installer_helper.dll",
"GoogleJapaneseInput": "GoogleIMEJaInstallerHelper.dll",
},
linkshared = True,
static_crt = True,
tags = MOZC_TAGS.WIN_ONLY,
target_compatible_with = ["@platforms//os:windows"],
Expand Down
2 changes: 2 additions & 0 deletions src/win32/tip/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ mozc_win32_cc_prod_binary(
"Mozc": "mozc_tip32.dll",
"GoogleJapaneseInput": "GoogleIMEJaTIP32.dll",
},
linkshared = True,
static_crt = True,
tags = MOZC_TAGS.WIN_ONLY,
target_compatible_with = ["@platforms//os:windows"],
Expand All @@ -96,6 +97,7 @@ mozc_win32_cc_prod_binary(
"/DEBUG:FULL",
"/PDBALTPATH:%_PDB%",
],
linkshared = True,
static_crt = True,
tags = MOZC_TAGS.WIN_ONLY,
target_compatible_with = ["@platforms//os:windows"],
Expand Down