feat: adds Globus GCS-sourced assets as a datasource #675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds integration with Globus. Specifically, adding the ability to source data via HTTPS on a Globus Connect Server instance, authenticated using Globus Auth.
credential_provider
was created based off of the#src/util/google_oauth2.ts
implementation and other OAuth-like credential providers (e.g.middleauth
andngauth
).The Globus credential provider uses PKCE for the authorization flow, which I've added a few basic utilities around 1.
@ravescovi has successfully deployed an instance of Neuroglancer configured with Globus using the proposed changes – much of this implementation is based on his initial work integrating with the Neuroglancer codebase.
We're looking forward to discussing the implementation and seeing what needs to be addressed to get this into the mainline!
Footnotes
These utilities could be replaced with an external library (e.g.
pkce-challenge
) if that is preferred. It might be worth noting many of added methods were pulled from the Globus SDK for JavaScript directly. ↩