Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color legend in the layer-bar #693

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
6c2d3e6
CC-127 Add first PoC about changing layer's title background color
aranega Nov 1, 2024
5dfafe8
Add first version of layer color widget
aranega Nov 12, 2024
6de87f1
Add first color widget in left layer bar
aranega Nov 12, 2024
4b79ce7
Add indicator to express that color is not visible even if active
aranega Nov 12, 2024
110b99b
Fix disposer logic for layer color computation
aranega Nov 13, 2024
9ea3b1e
Add support for color indicator for annotation layer
aranega Nov 21, 2024
149d030
Fix format
aranega Nov 26, 2024
4f8a477
Add color sync setting in layer state
aranega Nov 27, 2024
a3a2365
Add single color sync when only 1 label is visible in segmentation layer
aranega Nov 27, 2024
61a6c86
Fix color legend widget sync accross layerbar and layer panel
aranega Nov 27, 2024
ff96fd4
CC-167 update rainbow circle
Aiga115 Nov 27, 2024
f2e2111
Merge branch 'feature/CC-127' into feature/CC-167
Aiga115 Nov 27, 2024
f9cae7f
CC-167 reduce blur on rainbow circle
Aiga115 Nov 27, 2024
2229c8f
CC-167 update ui of circle labels
Aiga115 Nov 28, 2024
d5f9c52
Merge pull request #58 from MetaCell/feature/CC-167
aranega Dec 5, 2024
9d66b66
Fix rainbow color not removing when number of visible segment changes
aranega Dec 6, 2024
f33816a
Move color widget to the left of the title in layer bar
aranega Dec 6, 2024
340be26
Add general option for enabling/disabling color widget
aranega Dec 6, 2024
5aab0c4
Remove unused trackable boolean for color sync inside a layer
aranega Dec 6, 2024
91dbfba
Fix format
aranega Dec 6, 2024
83cde4f
Add layer bar color change on color seed change
aranega Dec 6, 2024
46c78e8
Refactor color widget in layer bar
aranega Dec 9, 2024
bddd998
Fix issue with color widget not updated when activated for the first
aranega Dec 17, 2024
491a15d
Fix unsupported style activation for layer list panel
aranega Dec 17, 2024
5b9fa3f
Merge branch 'master' into feature/CC-127
aranega Dec 17, 2024
b413a56
CC-189 make changes to ui of non color state circle
Aiga115 Dec 20, 2024
5e22083
Display a rainbow when the default annotation color is not used in the
aranega Dec 20, 2024
cd24b91
CC-189 remove comment
Aiga115 Dec 20, 2024
c9f8ecf
Change tooltip message for annotation with rainbow
aranega Dec 20, 2024
7ad72ff
Fix layer widget color not updating for annotation
aranega Dec 20, 2024
ec248e2
Merge branch 'feature/CC-127' of github.com:MetaCell/neuroglancer int…
aranega Dec 20, 2024
1f873d1
Merge pull request #60 from MetaCell/feature/CC-189
aranega Dec 20, 2024
e5fe020
CC-200 initial changes made
Aiga115 Dec 20, 2024
50cd9d2
Merge pull request #61 from MetaCell/feature/CC-200
aranega Dec 21, 2024
c42c86d
chore: formatting pass
seankmartin Jan 8, 2025
b9ed80d
feat: clarify tooltip for non-default color annotations
seankmartin Jan 8, 2025
1857d19
CC-127 Remove grid pattern when the layer type changes
aranega Jan 8, 2025
4fbb7b2
CC-127 Update color widget in the layer list when layer type changes
aranega Jan 8, 2025
66e6d39
CC-127 Add tooltip when the layer doesn't support color widget
aranega Jan 8, 2025
66405e1
CC-127 Remove redundant code for color widget from then layer list
aranega Jan 8, 2025
4520ef2
CC-127 Remove user-defined color for layers
aranega Jan 8, 2025
166ff6f
CC-127 Change setting label from color widget to color legend
aranega Jan 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CC-127 Change setting label from color widget to color legend
aranega committed Jan 8, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 166ff6fe2a541317395ad0b429ef7f6a8bf96d09
2 changes: 1 addition & 1 deletion src/ui/viewer_settings.ts
Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@ export class ViewerSettingsPanel extends SidePanel {
"Enable adaptive downsampling",
viewer.enableAdaptiveDownsampling,
);
addCheckbox("Enable layer color widget", viewer.enableLayerColorWidget);
addCheckbox("Enable layer color legend", viewer.enableLayerColorWidget);

const addColor = (label: string, value: WatchableValueInterface<vec3>) => {
const labelElement = document.createElement("label");