-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup golangci-lint
in full
#274
Comments
This was referenced Nov 14, 2024
copybara-service bot
pushed a commit
that referenced
this issue
Dec 4, 2024
This enables linters for ensuring that the result of assignments are actually used - I'm not actually sure of the difference between the two, but they both seem to be enabled by default and very quick, so I don't think it's a huge issue to have both Relates to #274 Closes #289 COPYBARA_INTEGRATE_REVIEW=#289 from ackama:linting/enable-wastedassign d7d9b73 PiperOrigin-RevId: 702772118
This was referenced Dec 4, 2024
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've opened #262 adding a basic configuration which is based off the one from
osv-scanner
, but due to type errors I've had to disable everything by default and manually re-enable specific rules - we should work towards getting all of the rules re-enabled, which'll include resolving the type error that I suspect is probably related to the protobuffer stuff.Relates to #158
containedctx
linter #395)copyloopvar
linter #320)depguarddupword
linter #321)errname
linter #394)forbidigo(test: forbid usingt.Parallel
#344)gochecknoinits
linter #288)golangci-lint
with a basic configuration #262 (comment))goimports
linter #332)Cracker
interface #334)ineffassign
andwastedassign
linters #289 / d3ab609)range
s where possible #331)misspell
linter #263)nilerr
linter #385)paralleltestt.Parallel
, see test: forbid usingt.Parallel
#344)predeclared
linter #299)t.Helper
is used #325)tparallelt.Parallel
, see test: forbid usingt.Parallel
#344)ineffassign
andwastedassign
linters #289 / d3ab609)whitespace
linter #315)The text was updated successfully, but these errors were encountered: