Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup golangci-lint in full #274

Open
18 of 46 tasks
G-Rath opened this issue Nov 6, 2024 · 0 comments
Open
18 of 46 tasks

Setup golangci-lint in full #274

G-Rath opened this issue Nov 6, 2024 · 0 comments

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented Nov 6, 2024

I've opened #262 adding a basic configuration which is based off the one from osv-scanner, but due to type errors I've had to disable everything by default and manually re-enable specific rules - we should work towards getting all of the rules re-enabled, which'll include resolving the type error that I suspect is probably related to the protobuffer stuff.

Relates to #158

copybara-service bot pushed a commit that referenced this issue Dec 4, 2024
This enables linters for ensuring that the result of assignments are actually used - I'm not actually sure of the difference between the two, but they both seem to be enabled by default and very quick, so I don't think it's a huge issue to have both

Relates to #274

Closes #289

COPYBARA_INTEGRATE_REVIEW=#289 from ackama:linting/enable-wastedassign d7d9b73
PiperOrigin-RevId: 702772118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant