test: forbid using t.Parallel
#344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
linting/prevent-t-parallel
branch
from
a9befea to
babf1f3
Compare
G-Rath
force-pushed
the
linting/prevent-t-parallel
branch
from
babf1f3 to
ec75397
Compare
another-rex
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal test runner used by Google gets confused by testing using
t.Paralleldue to the log lines getting mixed, so this removes all usage of it and configures theforbidigolinter to enforce it's not-use.Since this by extension means we never want the
tparallellinter enabled, I've updated the linting config to remove it from theenablelist and added it to the commented outdisablelist in preparation for when we're able to switch to having all linters enabled by default (as you're not allowed to use bothdisable-allanddisableat the same time)