ci: explore running linting on just new changes #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new temporary job that runs
golangci-lintwithonly-new-issuesenabled in the hopes that it'll reduce friction for contributions being made via GitHub by avoiding failing CI due to linting violations introduced through internal patches.As I've not had a lot of experience with this option and an incorrect setup with linters can often look the same as linting being happy unless someone actually takes the time to review the logs of every run, I've opted to start by introducing this as a second job with the idea being we'll get the see what the linter would give us with and without that option.
I expect after a bunch of pull requests, we'll have seen enough to decide if this option would actually be helpful, and either way remove one of the two jobs
Relates to #346