refactor: Vendored extractor osvdev #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
force-pushed
the
vendored-extractor-osvdev
branch
from
9a3f053 to
f05ac39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
+ Coverage 66.74% 66.80% +0.05%
==========================================
Files 198 198
Lines 18652 18658 +6
==========================================
+ Hits 12449 12464 +15
Misses 5515 5515
+ Partials 688 679 -9 ☔ View full report in Codecov by Sentry. |
oliverchang
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am attempting to split a big refactor PR into several small pieces, this is part 5,
This PR can be reviewed independently from part 4 (#1497) by just looking at the latest commit.
Update the vendored extractor to take and use the osvdev Client rather than calling the global osv function.