fix: Correctly set ARG and revert docker hash back to original version #1508
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, ARG only applies to the current FROM section, so all of the ARGs in our test docker files were placebo and didn't do anything. The variable was just empty and just installed whatever version npm felt like haha, this meant recently the image building broke as npm started trying to install a newer version of itself that's not compatible with the version of node this image is pinned to. E.g. https://github.com/google/osv-scanner/actions/runs/12821471894/job/35752742949?pr=1505
Also revert the change where I updated the sha, now keeps using the existing older sha for more results.