Add automatic linting. #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be required with the older version of Python 2.7.
This reverts commit c6360b4. It didn't help.
Suggested here for someone else with a similar (or identical) problem: pylint-dev/astroid#358 (comment)
eliahhecht
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed on issue #619.
This sets us up to use two tools for style/formatting checks:
This updates the tools/lint script (which doesn't work anymore as-is, at least not for me), to have options for yapf and pylint. Eventually, I'd like to get the whole codebase compliant, but that's not going to happen anytime soon, at least not from pylint's perspective. So, by default it has two separate lists of files to check (one for yapf and one for pylint). My plan is to ask people to run yapf anytime they touch a file, and to ensure that new files pass both yapf and pylint. I have no particular plan for how to get existing files in line with pylint (I wouldn't want to block PRs on updating any random file you touch); maybe I'll aim to fix two or three a week until it's done.