Feature/function arg wrapping #1127
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jesse-sony
force-pushed
the
feature/functionArgWrapping
branch
from
82d976d to
7c04ded
Compare
jesse-sony
force-pushed
the
feature/functionArgWrapping
branch
from
b7991b3 to
510ac63
Compare
This should be able to recurisively work its way down a stack of nested function calls to figure out whether wrapping is actually necessary.
Need to parse everything that isn't a special character instead of creating a restricted set of things that I will parse
And do not force breaks on commas in the middle of for comprehensions
jesse-sony
force-pushed
the
feature/functionArgWrapping
branch
from
83d912d to
cbf8550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second PR from me, but still haven't had one merged so definitely need to get the contributor stuff sorted, etc
This PR is to address issues that seem to have been raised in #590 and #978. basically when there are function calls with argument lists nested inside function calls with argument lists, yapf refuses to consider splitting the secondary argument lists which leads to it ignoring the penalty for splitting before the first argument or showing different behavior when arguments are functions vs not functions.
This PR tries to address this in as minimally invasive a way as possible by recursively calculating the length of nested function arguments and calculating whether it is possible to wrap them. This doesn't actually modify any of the wrapping logic, so it is still up to yapf how it wants to wrap stuff, it just removes MustSplit penalties in cases where they aren't actually necessary because args could be wrapped successfully.
There are no tests for this feature, so those will obviously have to be added as well before merging.