Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): Pass reverse flag from proxy to library #11395

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jan 8, 2025

b/387315971

This PR fixes following conformance tests:

  1. TestReadRows_NoRetry_OutOfOrderError_Reverse
=== RUN   TestReadRows_NoRetry_OutOfOrderError_Reverse
    readrows_test.go:168: 
        	Error Trace:	/usr/local/google/home/bahaaiman/Documents/cfdb-workspace-01/cloud-bigtable-clients-test/tests/readrows_test.go:168
        	Error:      	"out of order row key, must be strictly increasing. new key: \"row-01\" prev row: \"row-07\"" does not contain "decreasing"
        	Test:       	TestReadRows_NoRetry_OutOfOrderError_Reverse
    readrows_test.go:169: The full error message is: out of order row key, must be strictly increasing. new key: "row-01" prev row: "row-07"
--- FAIL: TestReadRows_NoRetry_OutOfOrderError_Reverse 

  1. TestReadRows_Retry_LastScannedRow_Reverse
=== RUN   TestReadRows_Retry_LastScannedRow_Reverse
    readrows_test.go:349: 
        	Error Trace:	/usr/local/google/home/bahaaiman/Documents/cfdb-workspace-01/cloud-bigtable-clients-test/tests/readrows_test.go:349
        	Error:      	Should be true
        	Test:       	TestReadRows_Retry_LastScannedRow_Reverse
--- FAIL: TestReadRows_Retry_LastScannedRow_Reverse 

Cause:
The proxy does not pass the reverse scan flag when calling the methods of the library

Fix:
Add ReverseScan flag in ReadRows call.

Logs after fix:

=== RUN   TestReadRows_NoRetry_OutOfOrderError_Reverse
    readrows_test.go:169: The full error message is: out of order row key, must be strictly decreasing. new key: "row-07" prev row: "row-03"
--- PASS: TestReadRows_NoRetry_OutOfOrderError_Reverse 
=== RUN   TestReadRows_Retry_LastScannedRow_Reverse
--- PASS: TestReadRows_Retry_LastScannedRow_Reverse 

@bhshkh bhshkh requested review from a team as code owners January 8, 2025 06:22
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 8, 2025
@bhshkh bhshkh enabled auto-merge (squash) January 8, 2025 18:33
@bhshkh bhshkh merged commit 7abfaaa into googleapis:main Jan 8, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants