Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): Convert entry error to status #11428

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jan 9, 2025

b/387315971
Fixes TestMutateRows_NoRetry_NonTransientErrors conformance test

=== RUN   TestMutateRows_NoRetry_NonTransientErrors
    mutaterows_test.go:184: 
        	Error Trace:	/usr/local/google/home/bahaaiman/Documents/cfdb-workspace-01/cloud-bigtable-clients-test/tests/mutaterows_test.go:184
        	Error:      	Not equal: 
        	            	expected: 7
        	            	actual  : 0
        	Test:       	TestMutateRows_NoRetry_NonTransientErrors
    mutaterows_test.go:184: 
        	Error Trace:	/usr/local/google/home/bahaaiman/Documents/cfdb-workspace-01/cloud-bigtable-clients-test/tests/mutaterows_test.go:184
        	Error:      	Not equal: 
        	            	expected: 7
        	            	actual  : 0
        	Test:       	TestMutateRows_NoRetry_NonTransientErrors
--- FAIL: TestMutateRows_NoRetry_NonTransientErrors 

In this test, the response returned by the library'y ApplyBulk method is

errs: [<nil>,  rpc error: code = PermissionDenied desc = , rpc error: code = PermissionDenied desc = , <nil>]
err: <nil>

Each of the errors in the errs variable should be converted to status to match the format expected by the test proto. This change is being in this PR.

After fix:

=== RUN   TestMutateRows_NoRetry_NonTransientErrors
--- PASS: TestMutateRows_NoRetry_NonTransientErrors (0.01s)
PASS
ok  	github.com/googleapis/cloud-bigtable-clients-test/tests	0.026s

@bhshkh bhshkh requested review from a team as code owners January 9, 2025 18:57
@bhshkh bhshkh requested a review from gkevinzheng January 9, 2025 18:58
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 9, 2025
@bhshkh bhshkh enabled auto-merge (squash) January 10, 2025 21:36
@bhshkh bhshkh merged commit c9113dd into googleapis:main Jan 10, 2025
8 of 10 checks passed
@bhshkh bhshkh deleted the test/cbt-TestMutateRows-NoRetry-NonTransientErrors branch January 10, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants