Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): fix mutex use and CloseSend before close #11432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shubham-diwakar
Copy link
Contributor

@shubham-diwakar shubham-diwakar commented Jan 10, 2025

  1. Make CloseSend() call before releasing resource.
  2. Make change to some mutex calls.
    Removed mutex call around getActiveRange as that will be called from one go routine at a single time.
    Added mutex call around streamReceiver ctx.Done() case similar to streamManager.
  3. Tested all MRD tests with -race.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 10, 2025
@shubham-diwakar shubham-diwakar marked this pull request as ready for review January 10, 2025 13:54
@shubham-diwakar shubham-diwakar requested review from a team as code owners January 10, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant