[skrifa] detect "tricky" fonts by family name #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the family name part of FreeType's "tricky" font detection. This is sufficient to address the problematic font in #1303. Adds an `OutlineGlyphCollection::require_interpreter()` method that can be used to determine if hinting (with the interpreter engine) is required to correctly render glyphs from the font. FreeType has some additional checks on length/checksums of various tables. I'll do that in a follow up.
dfrg
added a commit
that referenced
this pull request
Jan 7, 2025
Adds support for detecting trickiness based on checksum/length of the cvt, fpgm and prep tables. Note: I'm not able to actually find any of these fonts to test with. Also, to avoid redundancy, moves some checksum computation code out of write-fonts into read-fonts and makes it public. Based on #1305 which should land first.
Merged
drott
approved these changes
Jan 8, 2025
drott
reviewed
Jan 8, 2025
Generally avoid using the "tricky" FreeType-ism in names and comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the family name part of FreeType's "tricky" font detection. This is sufficient to address the problematic font in #1303.
Adds an
OutlineGlyphCollection::require_interpreter()method that can be used to determine if hinting (with the interpreter engine) is required to correctly render glyphs from the font.FreeType has some additional checks on length/checksums of various tables. I'll do that in a follow up.