Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firefox-manifest to resolve warnings #256

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Pharb
Copy link
Member

@Pharb Pharb commented Oct 4, 2024

Fixes:

Code                              Message                                       Description                                                                                     File
APPLICATIONS_DEPRECATED           Use "browser_specific_settings" instead of    The "applications" property in the manifest is deprecated and will no longer be accepted in     manifest.json
                                  "applications".                               Manifest Version 3 and above.
KEY_FIREFOX_ANDROID_UNSUPPORTE…   Manifest key not supported by the specified   "strict_min_version" requires Firefox for Android 60, which was released before version 79      manifest.json

Code                              Message                                       Description                                                                                     File
APPLICATIONS_DEPRECATED           Use "browser_specific_settings" instead of    The "applications" property in the manifest is deprecated and will no longer be accepted in     manifest.json
                                  "applications".                               Manifest Version 3 and above.
KEY_FIREFOX_ANDROID_UNSUPPORTE…   Manifest key not supported by the specified   "strict_min_version" requires Firefox for Android 60, which was released before version 79      manifest.json

Signed-off-by: Patrick Harböck <[email protected]>
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ad243f8) to head (14e2453).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #256   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          738       738           
  Branches       135       135           
=========================================
  Hits           738       738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pharb Pharb merged commit 5b69c1c into master Oct 4, 2024
11 checks passed
@Pharb Pharb deleted the update-manifest-fix-warnings branch October 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant