Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression in examples introduced by #753 #759

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

vdwees
Copy link
Contributor

@vdwees vdwees commented Dec 13, 2024

It looks like there was a mistake when updating the examples. (err == nil should be err != nil)

The broken commit: f3e85a2

@vdwees vdwees changed the title fix: regression in examples introduced by #753 fix: regression in examples introduced by https://github.com/gopcua/opcua/pull/753 Dec 13, 2024
@vdwees vdwees changed the title fix: regression in examples introduced by https://github.com/gopcua/opcua/pull/753 fix: regression in examples introduced by #753 Dec 13, 2024
@vdwees vdwees changed the title fix: regression in examples introduced by #753 fix: regression in examples introduced by !753 Dec 13, 2024
@vdwees vdwees changed the title fix: regression in examples introduced by !753 fix: regression in examples introduced by f3e85a2928361e16b0b577a1255a45e628986177 Dec 13, 2024
@vdwees vdwees changed the title fix: regression in examples introduced by f3e85a2928361e16b0b577a1255a45e628986177 fix: regression in examples introduced by #753 Dec 13, 2024
@vdwees
Copy link
Contributor Author

vdwees commented Dec 16, 2024

@magiconair should I make an issue for this one as well?

@magiconair
Copy link
Member

No, that's fine. Thank you!

@magiconair magiconair enabled auto-merge December 16, 2024 12:45
@magiconair magiconair added this to the v0.6.2 milestone Dec 16, 2024
@magiconair magiconair merged commit 74c8438 into gopcua:main Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants