Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: if a different type in slice, raise error #212

Merged
merged 8 commits into from
May 4, 2024
Merged

feat: if a different type in slice, raise error #212

merged 8 commits into from
May 4, 2024

Conversation

lll-lll-lll-lll
Copy link
Contributor

@lll-lll-lll-lll lll-lll-lll-lll commented Apr 6, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

@lll-lll-lll-lll lll-lll-lll-lll marked this pull request as ready for review April 9, 2024 21:40
zak905
zak905 reviewed Apr 10, 2024
View reviewed changes
decoder.go Outdated Show resolved Hide resolved
@lll-lll-lll-lll lll-lll-lll-lll requested a review from zak905 April 14, 2024 02:57
zak905
zak905 reviewed Apr 14, 2024
View reviewed changes
decoder_test.go Outdated Show resolved Hide resolved
@lll-lll-lll-lll lll-lll-lll-lll requested a review from zak905 April 16, 2024 22:14
zak905
zak905 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@zak905 zak905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - waiting for the maintainers to get this in.

@AlexVulaj
Copy link
Member

@lll-lll-lll-lll thanks for the contribution! and @zak905 thanks a ton for the review. I've given this another look over and all looks good to me.

@AlexVulaj AlexVulaj merged commit a377fd6 into gorilla:main May 4, 2024
10 checks passed
@zak905
Copy link
Contributor

zak905 commented May 4, 2024

Welcome, anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVulaj AlexVulaj AlexVulaj approved these changes

@zak905 zak905 zak905 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] Is ignoring mismatched slice element types intended behavior?
3 participants
@lll-lll-lll-lll @AlexVulaj @zak905