support development Go version #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sivchari <[email protected]>
tenntenn
requested changes
Nov 15, 2024
v2/skeleton/skeleton.go
Outdated
| if strings.HasPrefix(gover, "devel ") { | ||
| // The devel format is like following. | ||
| // devel go1.24-xxxxxxxxxx Day Date Mon Time Arch" | ||
| gover = strings.Split(strings.TrimPrefix(gover, "devel "), "-")[0] |
There was a problem hiding this comment.
Could you use strings.Cut instead of strings.Split?
There was a problem hiding this comment.
It's reasonable, thanks. I fixed it.
Signed-off-by: sivchari <[email protected]>
Merged
|
Hi, @tenntenn
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #78
I supported development Go version.
In additional, I filed the patches to skeletonkit, too. When it will be merged, I upgrade the dependency of skeletonkit.