fix: tests

goto · Jan 9, 2025 · 3082020 · 3082020
1 parent 70f3ef9
commit 3082020
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/scheduler/service/deployment_service_test.go b/core/scheduler/service/deployment_service_test.go
@@ -340,7 +340,7 @@ func TestDeploymentService(t *testing.T) {
 			defer mScheduler.AssertExpectations(t)
 
 			runService := service.NewJobRunService(logger, jobRepo, nil, nil, nil,
-				mScheduler, priorityResolver, nil, nil, nil, nil)
+				mScheduler, priorityResolver, nil, nil, nil)
 
 			err := runService.UploadJobs(ctx, tnnt1, jobNamesToUpload, jobNamesToDelete)
 			assert.ErrorContains(t, err, upstreamErr)

diff --git a/ext/sheets/gsheet/sheet_info_test.go b/ext/sheets/gsheet/sheet_info_test.go
@@ -21,15 +21,15 @@ func TestSheetInfo(t *testing.T) {
 
 		info, err := gsheet.FromURL(u1)
 		assert.Nil(t, err)
-		assert.Equal(t, info.SheetID, "abcedefgh")
-		assert.Equal(t, info.GID, "")
+		assert.Equal(t, "abcedefgh", info.SheetID)
+		assert.Equal(t, int64(-1), info.GID)
 	})
 	t.Run("return sheet info with sid and gid", func(t *testing.T) {
 		u1 := "https://docs.google.com/spreadsheets/d/abcdeghi/edit#gid=3726"
 
 		info, err := gsheet.FromURL(u1)
 		assert.Nil(t, err)
-		assert.Equal(t, info.SheetID, "abcdeghi")
-		assert.Equal(t, info.GID, "3726")
+		assert.Equal(t, "abcdeghi", info.SheetID)
+		assert.Equal(t, int64(3726), info.GID)
 	})
 }