test: for substitude single quote

client/cmd/job/run_input.go

@@ -156,15 +156,8 @@ func (j *jobRunInputCommand) writeInstanceResponse(jobResponse *pb.JobRunInputRe
 func (j *jobRunInputCommand) writeJobResponseSecretToFile(
 	jobResponse *pb.JobRunInputResponse, dirPath string,
 ) error {
-	// write all secrets into a file
-	secretsFileContent := ""
-	for key, val := range jobResponse.Secrets {
-		if strings.Contains(val, unsubstitutedValue) {
-			j.keysWithUnsubstitutedValue = append(j.keysWithUnsubstitutedValue, key)
-		}
-		escapedVal := strings.ReplaceAll(val, "'", "'\\''")
-		secretsFileContent += fmt.Sprintf("%s='%s'\n", key, escapedVal)
-	}
+	secretsFileContent, keysWithUnsubstitutedValue := ConstructConfigEnvSourcingContent(jobResponse.Envs)
+	j.keysWithUnsubstitutedValue = append(j.keysWithUnsubstitutedValue, keysWithUnsubstitutedValue...)
 
 	filePath := filepath.Join(dirPath, typeSecretFileName)
 	writeToFileFn := utils.WriteStringToFileIndexed()
@@ -175,14 +168,8 @@ func (j *jobRunInputCommand) writeJobResponseSecretToFile(
 }
 
 func (j *jobRunInputCommand) writeJobResponseEnvToFile(jobResponse *pb.JobRunInputResponse, dirPath string) error {
-	envFileBlob := ""
-	for key, val := range jobResponse.Envs {
-		if strings.Contains(val, unsubstitutedValue) {
-			j.keysWithUnsubstitutedValue = append(j.keysWithUnsubstitutedValue, key)
-		}
-		escapedVal := strings.ReplaceAll(val, "'", "'\\''")
-		envFileBlob += fmt.Sprintf("%s='%s'\n", key, escapedVal)
-	}
+	envFileBlob, keysWithUnsubstitutedValue := ConstructConfigEnvSourcingContent(jobResponse.Envs)
+	j.keysWithUnsubstitutedValue = append(j.keysWithUnsubstitutedValue, keysWithUnsubstitutedValue...)
 
 	filePath := filepath.Join(dirPath, typeEnvFileName)
 	writeToFileFn := utils.WriteStringToFileIndexed()
@@ -192,6 +179,17 @@ func (j *jobRunInputCommand) writeJobResponseEnvToFile(jobResponse *pb.JobRunInp
 	return nil
 }
 
+func ConstructConfigEnvSourcingContent(config map[string]string) (content string, keysWithUnsubstitutedValue []string) {
+	for key, val := range config {
+		if strings.Contains(val, unsubstitutedValue) {
+			keysWithUnsubstitutedValue = append(keysWithUnsubstitutedValue, key)
+		}
+		escapedVal := strings.ReplaceAll(val, "'", "'\\''")
+		content += fmt.Sprintf("%s='%s'\n", key, escapedVal)
+	}
+	return content, keysWithUnsubstitutedValue
+}
+
 func (j *jobRunInputCommand) writeJobAssetsToFiles(
 	jobResponse *pb.JobRunInputResponse, dirPath string,
 ) error {

client/cmd/job/run_input_test.go

@@ -0,0 +1,33 @@
+package job_test
+
+import (
+	"testing"
+
+	"github.com/goto/optimus/client/cmd/job"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestConstructConfigEnvSourcingContent(t *testing.T) {
+	t.Run("construct content with unsubstitude value", func(t *testing.T) {
+		config := map[string]string{
+			"EXAMPLE": "<no value>",
+			"ANOTHER": "hello",
+		}
+		content, keys := job.ConstructConfigEnvSourcingContent(config)
+		assert.Len(t, keys, 1)
+		assert.Equal(t, `EXAMPLE='<no value>'
+ANOTHER='hello'
+`, content)
+	})
+	t.Run("construct content with single quote in it", func(t *testing.T) {
+		config := map[string]string{
+			"EXAMPLE": "value with 'single quote'",
+			"ANOTHER": "hello",
+		}
+		content, keys := job.ConstructConfigEnvSourcingContent(config)
+		assert.Len(t, keys, 0)
+		assert.Equal(t, `EXAMPLE='value with '\''single quote'\'''
+ANOTHER='hello'
+`, content)
+	})
+}