Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: concurrency issue replay #174

Merged
merged 4 commits into from
Nov 14, 2023
Merged

fix: concurrency issue replay #174

merged 4 commits into from
Nov 14, 2023

Conversation

deryrahman
Copy link
Member

  • use skip lock for queue-like mechanism when fetching the eligible replay
  • reorder the way we update the replay runs
  • use update instead of reinserting the updated runs

@deryrahman deryrahman force-pushed the fix-concurrency-issue-replay branch from 1c90244 to f5d0cf3 Compare November 8, 2023 04:10
@deryrahman deryrahman merged commit 5151101 into main Nov 14, 2023
3 checks passed
@deryrahman deryrahman deleted the fix-concurrency-issue-replay branch November 14, 2023 07:14
irainia pushed a commit that referenced this pull request Dec 5, 2023
@deryrahman @irainia
fix: concurrency issue replay (#174)
043703a 
* feat: use skip lock for update and get replay

* feat: reorder the flow of update runs on worker

* feat: use transaction to update all runs status

* refactor: direct return toReplay(replayRuns) instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbchaos sbchaos sbchaos left review comments

@arinda-arif arinda-arif arinda-arif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deryrahman @sbchaos @arinda-arif