fix: fix app.mjs panic and create settings.json on startup #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
requested review from
cjellick,
njhale,
StrongMonkey,
ryanhopperlowe and
g-linville
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
issue-480
branch
from
72a97c1 to
cead33b
Compare
g-linville
previously approved these changes
Sep 10, 2024
| // If the app settings file doesn't exist, create it with default settings. | ||
| if (!existsSync(config.appSettingsFile)) { | ||
| writeFileSync( | ||
| config.appSettingsFile, // created in config.mjs |
There was a problem hiding this comment.
nit: I think this comment is out of date?
Suggested change
| config.appSettingsFile, // created in config.mjs | |
| config.appSettingsFile, |
There was a problem hiding this comment.
Its new, I added it just now. What's wrong with it?
| headless: true, | ||
| }, | ||
| }; | ||
| if (existsSync(settingsLocation)) { |
There was a problem hiding this comment.
Nit: probably more safe to use default setting when file exists and parsing is correct, otherwise fallback to default file. In case the setting file is corrupted...
There was a problem hiding this comment.
@StrongMonkey Can you take another look? I added some things to defend against malformed files.
StrongMonkey
previously approved these changes
Sep 10, 2024
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
dismissed stale reviews from StrongMonkey and g-linville
via
4a406cf
ryanhopperlowe
approved these changes
Sep 10, 2024
g-linville
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some issues that were not caught in the last PR because a lot of the reviewers already had settings files. I didn't catch it while programming the settings page up for the same reason, to fix this this PR does 3 things.
#480
https://acorn-io.slack.com/archives/C03FU91U4SX/p1725985732395979