Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: verify system tool is whitelisted when adding tools #502

Merged
merged 2 commits into from
Sep 12, 2024
Merged

enhance: verify system tool is whitelisted when adding tools #502

merged 2 commits into from
Sep 12, 2024

Conversation

ryanhopperlowe
Copy link
Contributor

No description provided.

tylerslaton
tylerslaton reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@tylerslaton tylerslaton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an issue associated with this, was this an ask from Craig or someone?

@ryanhopperlowe
Copy link
Contributor Author

ryanhopperlowe commented Sep 12, 2024 •
edited
Loading

I don't see an issue associated with this, was this an ask from Craig or someone?

@tylerslaton Yes, It is related to #296

I added a comment there for context

tylerslaton
tylerslaton approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ryanhopperlowe ryanhopperlowe merged commit 91e0a03 into gptscript-ai:main Sep 12, 2024
1 check passed
@ryanhopperlowe ryanhopperlowe deleted the enhance/validate-system-tools-on-add branch September 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerslaton tylerslaton tylerslaton approved these changes

@cjellick cjellick Awaiting requested review from cjellick

@thedadams thedadams Awaiting requested review from thedadams

@StrongMonkey StrongMonkey Awaiting requested review from StrongMonkey

@g-linville g-linville Awaiting requested review from g-linville

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanhopperlowe @g-linville @tylerslaton