Skip to content

Commit

Permalink
apply to nullable arguments as well
Browse files Browse the repository at this point in the history
  • Loading branch information
kainino0x committed Dec 17, 2024
1 parent c3564eb commit b9b7daa
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Most or all of these should be fixed in the generator over time.
- `Array` changed to `Iterable` for WebIDL `sequence`s in argument positions (but not in return positions).
- `any` changed to `object` for WebIDL `object`.
- `| SharedArrayBuffer` added for `[AllowShared] BufferSource`.
- `| null` changed to `| null | undefined` for WebIDL `?` items in `sequence`s.
- `| null` changed to `| null | undefined` for WebIDL nullable items (`T?`).

The following differences are TODO: should be changed in the final result.

Expand Down
15 changes: 12 additions & 3 deletions dist/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1730,7 +1730,10 @@ interface GPUBindingCommandsMixin {
*/
setBindGroup(
index: GPUIndex32,
bindGroup: GPUBindGroup | null,
bindGroup:
| GPUBindGroup
| null
| undefined,
dynamicOffsets?: Iterable<GPUBufferDynamicOffset>
): undefined;
/**
Expand All @@ -1746,7 +1749,10 @@ interface GPUBindingCommandsMixin {
*/
setBindGroup(
index: GPUIndex32,
bindGroup: GPUBindGroup | null,
bindGroup:
| GPUBindGroup
| null
| undefined,
dynamicOffsetsData: Uint32Array,
dynamicOffsetsDataStart: GPUSize64,
dynamicOffsetsDataLength: GPUSize32
Expand Down Expand Up @@ -1824,7 +1830,10 @@ interface GPURenderCommandsMixin {
*/
setVertexBuffer(
slot: GPUIndex32,
buffer: GPUBuffer | null,
buffer:
| GPUBuffer
| null
| undefined,
offset?: GPUSize64,
size?: GPUSize64
): undefined;
Expand Down

0 comments on commit b9b7daa

Please sign in to comment.