New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend integration tests #176

Merged

bigdaz merged 1 commit into gradle:main from Marcono1234:integration-tests

Feb 7, 2024

Contributor

Marcono1234 commented Feb 3, 2024 •

edited

Loading

Tries to extend the existing integration tests by:

Running npm run build on pull requests to update dist/index.js, because pull requests are not expected to update it, see comments on #171
Otherwise the integration tests would just check the state of main and would not detect if the pull request actually breaks validation in some way.
Checking outputs.failed-wrapper to contain the expected string
Adding a test for expected failing validation

Here are two examples from my fork:

Any feedback is appreciated!

(This pull request also changes npm install to npm clean-install to detect an outdated package-lock.json instead of silently updating it.)


          Extend integration tests

6826f9e

bigdaz merged commit ca85ed0 into gradle:main

6 checks passed

Member

bigdaz commented Feb 7, 2024

Fantastic! Thanks for the improvements.

Marcono1234 deleted the integration-tests branch

February 7, 2024 16:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet