Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log multiple errors #180

Closed
wants to merge 1 commit into from
Closed

Log multiple errors #180

wants to merge 1 commit into from

Conversation

deejay1
Copy link
Contributor

@deejay1 deejay1 commented Feb 6, 2024

What

Log AggregateError type, when multiple errors are returned from HTTP client - fixes #174

Why

We would silently fail otherwise as error.message was empty for the AggregatedError exception.

# What
Log AggregateError type, when multiple errors are returned
from HTTP client - fixes #174

# Why
We would silently fail otherwise as error.message was empty
for the AggregatedError exception.
@bigdaz bigdaz changed the base branch from main to releases/v2 February 6, 2024 15:11
@bigdaz bigdaz changed the base branch from releases/v2 to main February 6, 2024 15:11
@bigdaz
Copy link
Member

bigdaz commented Feb 6, 2024

Thanks! I'll merge this into releases/v2, so that we can put out a v2.0.1 patch release without incorporating the other changes.

I'd rather defer releasing v2.1.0 with the "hardcoded checksums" work until I have capacity to handle any issues.

@bigdaz
Copy link
Member

bigdaz commented Feb 6, 2024

Merged and released as v2.0.1. Thanks!

@bigdaz bigdaz closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After migration from v1 to v2 silently fails
2 participants