Add exclusion rules for prom operator objects and static label helpers #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petewall
requested review from
a team,
skl,
nevermind89x,
jewbetcha and
sleepyfoodie
and removed request for
a team
skl
approved these changes
Jan 16, 2025
| @@ -109,3 +111,9 @@ Be sure perform actual integration testing in a live environment in the main [k8 | |||
| | serviceMonitors.namespaces | list | `[]` | Which namespaces to look for ServiceMonitor objects. | | |||
| | serviceMonitors.scrapeInterval | string | 60s | How frequently to scrape metrics from ServiceMonitor objects. Only used if the ServiceMonitor does not specify the scrape interval. Overrides global.scrapeInterval | | |||
| | serviceMonitors.selector | string | `""` | Selector to filter which ServiceMonitor objects to use. | | |||
|
|
|||
| ### ServiceMonitor | |||
There was a problem hiding this comment.
Think this broke out into its own section by accident
Suggested change
| ### ServiceMonitor | |
| ### ServiceMonitors |
There was a problem hiding this comment.
Thanks. I'll fix that...
petewall
force-pushed
the
feat/namespaceExclusions
branch
from
e0a8240 to
60bf6fa
Compare
Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
petewall
force-pushed
the
feat/namespaceExclusions
branch
from
af8cca6 to
bd4a7ab
Compare
It'll be dropped later, and it's required for the integration matcher later Signed-off-by: Pete Wall <[email protected]>
petewall
force-pushed
the
feat/namespaceExclusions
branch
from
bd4a7ab to
a4bbf59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-arranged the log processing a bit so extraLogProcessingStages are at the very end.