Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kepler to gather energy usage data #530

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add Kepler to gather energy usage data #530

merged 2 commits into from
Jul 5, 2024

Conversation

petewall
Copy link
Collaborator

@petewall petewall commented May 15, 2024

This PR adds Kepler as another subchart dependency. This means that we can optionally deploy Kepler and tell Alloy to scrape metrics from it.

Notes to reviewers:

  • The values.yaml file is the main interface for the helm chart.
    • The metrics.kepler section controls how we configure alloy to scrape kepler
    • The kepler section controls how kepler is deployed.
  • .github are for actions, mostly around the tooling that keeps kepler helm chart up to date.
  • charts/k8s-monitoring/ci/*.values.yaml are the test files for our CI tooling. Kepler is enabled in one of those files and we add a check for a known metric to ensure that end-to-end delivery is working
  • anything inside of examples are automatically generated

@petewall petewall self-assigned this May 15, 2024
@petewall petewall linked an issue May 15, 2024 that may be closed by this pull request
@petewall petewall marked this pull request as draft May 15, 2024 22:55
@petewall petewall marked this pull request as ready for review June 9, 2024 15:56
@petewall petewall force-pushed the feat/kepler branch 4 times, most recently from 476db3a to b282d00 Compare July 3, 2024 20:35
@petewall petewall requested a review from skl July 3, 2024 20:37
@petewall
Copy link
Collaborator Author

petewall commented Jul 3, 2024

Ignore the failing markdownlint error. That's a known problem with the data in the README.

@petewall petewall requested review from jjo, nikimanoledaki, a team, nevermind89x and jewbetcha and removed request for a team July 3, 2024 21:44
Signed-off-by: Pete Wall <[email protected]>
Copy link
Member

@skl skl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌍


# @ignored -- This skips including these values in README.md
canMount:
usrSrc: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

values.yaml does have a nodeSelector field defaulting to

nodeSelector:
  kubernetes.io/os: linux

, suggest adding also amd64 constraint, as per https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-arch

  kubernetes.io/arch: amd64

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I really thought about adding this. My hesitation is that there are ARM platforms that are supported, and I don't want to cut them out.

Is it easier to have the amd64 restriction and have to explain how to remove if you have a supported arm node, or don't have the restriction and have a doc about why pods are crashing on graviton nodes. I'm leaning towards the latter, but happy to discuss.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked a long time to determine if I can detect if the pod is on a graviton node, but I don't think it's possible at pod scheduling time.

charts/k8s-monitoring/values.yaml Show resolved Hide resolved
Copy link
Collaborator

@jjo jjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is greatO

@petewall petewall merged commit 8babe7b into main Jul 5, 2024
15 of 16 checks passed
@petewall petewall deleted the feat/kepler branch July 5, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add the ability to deploy Kepler
3 participants