-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kepler to gather energy usage data #530
Conversation
476db3a
to
b282d00
Compare
Ignore the failing |
Signed-off-by: Pete Wall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌍
|
||
# @ignored -- This skips including these values in README.md | ||
canMount: | ||
usrSrc: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
values.yaml
does have a nodeSelector
field defaulting to
nodeSelector:
kubernetes.io/os: linux
, suggest adding also amd64 constraint, as per https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-arch
kubernetes.io/arch: amd64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I really thought about adding this. My hesitation is that there are ARM platforms that are supported, and I don't want to cut them out.
Is it easier to have the amd64 restriction and have to explain how to remove if you have a supported arm node, or don't have the restriction and have a doc about why pods are crashing on graviton nodes. I'm leaning towards the latter, but happy to discuss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked a long time to determine if I can detect if the pod is on a graviton node, but I don't think it's possible at pod scheduling time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is greatO
Signed-off-by: Pete Wall <[email protected]>
This PR adds Kepler as another subchart dependency. This means that we can optionally deploy Kepler and tell Alloy to scrape metrics from it.
Notes to reviewers:
metrics.kepler
section controls how we configure alloy to scrape keplerkepler
section controls how kepler is deployed..github
are for actions, mostly around the tooling that keeps kepler helm chart up to date.charts/k8s-monitoring/ci/*.values.yaml
are the test files for our CI tooling. Kepler is enabled in one of those files and we add a check for a known metric to ensure that end-to-end delivery is workingexamples
are automatically generated