Always call tpl outside of with blocks to preserve backwards compatibility

[petewall]

Even though this functionality was fixed in 3.14, some systems (like ArgoCD) might not be able to upgrade so quickly or easily.

Notes for reviewers: . is the current context, which gets modified by with or with range, $ is always the top context. It's just good practice to use $, which is why this one didn't need to change: charts/k8s-monitoring/templates/extra-manifests.yaml

[petewall]

Installed Helm 3.10:

% ./helm version
version.BuildInfo{Version:"v3.10.3", GitCommit:"835b7334cfe2e5e27870ab3ed4135f136eecc704", GitTreeState:"clean", GoVersion:"go1.18.9"}

Using the published chart:

% ./helm template k8smon grafana/k8s-monitoring -f charts/k8s-monitoring/ci/ci-2-values.yaml          
Error: template: k8s-monitoring/templates/hooks/validate-configuration.yaml:126:8: executing "k8s-monitoring/templates/hooks/validate-configuration.yaml" at <include "alloyEventsConfig" .>: error calling include: template: k8s-monitoring/templates/_configs.tpl:105:6: executing "alloyEventsConfig" at <include "alloy.config.logs.cluster_events" .>: error calling include: template: k8s-monitoring/templates/alloy_config/_cluster_events.alloy.txt:17:3: executing "alloy.config.logs.cluster_events" at <tpl .extraStageBlocks .>: error calling tpl: cannot retrieve Template.Basepath from values inside tpl function: stage.static_labels {
  values = {
    color = "red",
  }
}
: "BasePath" is not a value

Use --debug flag to render out invalid YAML

Using the changes in the PR:

% ./helm template k8smon -n monitoring charts/k8s-monitoring -f charts/k8s-monitoring/ci/ci-2-values.yaml
---
# Source: k8s-monitoring/charts/alloy-events/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
...

[skl]

Awesome PR description and testing comment! 🚀 💯