Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Credentials From References #566

Closed
wants to merge 17 commits into from

Conversation

bentonam
Copy link
Collaborator

No description provided.

@bentonam bentonam requested a review from petewall June 10, 2024 03:48
@bentonam bentonam added the enhancement New feature or request label Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bentonam Hi, we noticed you made a commit in GitHub that may contain sensitive information (details below). Please double check if you intended to include or share this sensitive information in the issue.

Note that it may have already been addressed automatically by an administrator.

What types of sensitive information were detected?
Password with Exclusions

What was the context?

.: pyroscope-password: SX******************… ```
.: loki-password: SX******************… tempo-host: aH
.: tempo-password: SX******************… pyroscope-host
.: prometheus-password: SX******************… loki-host: aHR

When did this happen?
Mon, 10 Jun 2024 at 13:26:44 UTC

Where did this happen?
Repository: k8s-monitoring-helm
File Path: examples/credentials-from/README.md

What can I do now?
Please review the incident details carefully and help us remediate with these actions
Report as False Positive
Provide Business Justification

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bentonam Hi, we noticed you made a commit in GitHub that may contain sensitive information (details below). Please double check if you intended to include or share this sensitive information in the issue.

Note that it may have already been addressed automatically by an administrator.

What types of sensitive information were detected?
API Key: Google API

What was the context?

7: value: "AI******************…" - name:

When did this happen?
Mon, 10 Jun 2024 at 13:26:44 UTC

Where did this happen?
Repository: k8s-monitoring-helm
File Path: examples/credentials-autoconfigure-grafana-cloud/output.yaml

What can I do now?
Please review the incident details carefully and help us remediate with these actions
Report as False Positive
Provide Business Justification

@petewall petewall force-pushed the feat/creditnals-from branch 2 times, most recently from 2c23cfc to 2a5725a Compare July 5, 2024 20:33
@petewall petewall force-pushed the feat/creditnals-from branch from 9f92ff2 to 267ead4 Compare July 16, 2024 18:38
Signed-off-by: Pete Wall <[email protected]>
@petewall petewall force-pushed the feat/creditnals-from branch from 267ead4 to 5aadbb2 Compare July 16, 2024 18:58
@petewall petewall added this to the 2.0 milestone Sep 11, 2024
@petewall
Copy link
Collaborator

Closing this, because it'll be properly handled in 2.0

@petewall petewall closed this Oct 31, 2024
@petewall petewall deleted the feat/creditnals-from branch November 22, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants