fix nil pointer dereference

grafana · Apr 28, 2023 · db814be · db814be
1 parent 5910271
commit db814be
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/sql.go b/sql.go
@@ -76,12 +76,13 @@ func (*SQL) Open(database string, connectionString string) (*dbsql.DB, error) {
 // providing results as a slice of KeyValue instance(s) if available.
 func (*SQL) Query(db *dbsql.DB, query string, args ...interface{}) ([]KeyValue, error) {
 	rows, err := db.Query(query, args...)
-	defer func() {
-		_ = rows.Close()
-	}()
 	if err != nil {
 		return nil, err
 	}
+
+	defer func() {
+		_ = rows.Close()
+	}()
 	if rows.Err() != nil {
 		return nil, rows.Err()
 	}